Fix performance issue #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andy840119
force-pushed
the
fix-performance-issue
branch
from
bb16a32 to
4d75b2c
Compare
added 2 commits
October 11, 2021 12:06
also prevent duplicated destroy and create if shaders are the same.
…highly related to shader. it might cause not found issue if changing frame buffer dictionary and drawing at the same time.
andy840119
force-pushed
the
fix-performance-issue
branch
from
4d75b2c to
f45d0b5
Compare
|
GC works in framework test, but not really not sure why not working in ruleset 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue found in #64
And what's fixed in this PR:
CreateDrawNode()will call 3 times if create a drawable(got no reason why 🤔 )GLWrapper.ScheduleDisposal(() => Dispose(true))and only dispose unneed frame buffer.MultiShaderBufferedDrawNodeSharedData(code quality issue).